“You don’t have the hiring and firing power.”
– Kitty, Arrested Development
The real problem is merging before waiting for that one slow CI pipeline to complete
One problem is GHs auto-merge when ready button. It will merge when there are still tests running unless they are required. It would be much better if the auto merges took into account all checks and not just required ones.
Devs make mistakes. We want to put up guardrails so mistakes don’t hurt us so much.
Please don’t deliberately line the guardrails with barbed wire.
You work somewhere where the tests don’t always fail???
You just guessed my job lol
I mean what’s the point of your test if they fail. It’s already bad enough that one of our test is flacky. To be fair I am working in a company that does a lot of system safety and a lot of our stuff isn’t just tested, it’s mathematicaly proven.
Shit! You got deadlines, and managers or customers piling in? Yeah, they don’t pass, but who cares! The code works….probably! Ship it!
LG2M ✅
This just sounds like “my frontend only changes shouldn’t be impacted by some dumbass breaking backend two commits ago”, which seems reasonable.
Imagine having unit tests, my company could never
Sure, but do you want to risk catastrophy as a way to filter out bad developers?
We have a few non-required checks here and there - mostly as you need an admin to list a check as required and that can be annoying to do. And we still get code merged in occasionally that fails those checks. Hell, I have merged in code that fails the checks. Sometimes checks take a while to run, and there is this nice merge when ready button in GH. But it will gladly merge your code in once all the required checks have passed ignoring any non-required checks.
And it is such a useful button to have, especially in a large codebase with lots of developers - just merge in the code when it is ready and avoid forgetting about things for a few hours and possibly having to rebase and run all the checks again because of some minor merge conflict…
But GH required checks are just broken for large code bases as well. We don’t always want to run every check on every code change. We don’t need to run all unit tests when only a documentation has changed. But required checks are all or nothing. They need to return something or else you cannot merge at all (though this might apply to external checks more then gh actions maybe). I really wish there was a require all checks to pass and a at least one check must run. Or if external checks could tell GH when they are required or not. Either way there is a lot of room for improvement on the GH PR checks.
