If small numbers are much more frequent, it’s better to return early. Really, you should gather statistics about the numbers the function is called with, and put the most frequent ones at the top.
But this way your buddy in QA can build extra test cases and pay you back when he wins an award for most test cases created or some other corporate nonsense.
So to see what’s returned for 3 for example you would have to check the entire function to see if it’s not matched somewhere below and that if actually gets to the default return. This way the first time it matches 3 you can stop reading. It’s has better maintainability.
You could save about half the code by only listing one boolean value and having the other as a default return at the bottom.
Sometimes my genius is almost frightening.
If small numbers are much more frequent, it’s better to return early. Really, you should gather statistics about the numbers the function is called with, and put the most frequent ones at the top.
But this way your buddy in QA can build extra test cases and pay you back when he wins an award for most test cases created or some other corporate nonsense.
So to see what’s returned for 3 for example you would have to check the entire function to see if it’s not matched somewhere below and that if actually gets to the default return. This way the first time it matches 3 you can stop reading. It’s has better maintainability.